update dependencies #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -17,7 +18,8 @@ void main() { | |||
| }); | |||
|
|
|||
| tearDown(() { | |||
| channel.setMockMethodCallHandler(null); | |||
| TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger | |||
There was a problem hiding this comment.
Suggested change
| TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger | |
| TestDefaultBinaryMessengerBinding.instance?.defaultBinaryMessenger |
a ? is required for me on dart 2.19.6
| @@ -8,7 +8,8 @@ void main() { | |||
| TestWidgetsFlutterBinding.ensureInitialized(); | |||
|
|
|||
| setUp(() { | |||
| channel.setMockMethodCallHandler((MethodCall methodCall) async { | |||
| TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger | |||
There was a problem hiding this comment.
Suggested change
| TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger | |
| TestDefaultBinaryMessengerBinding.instance?.defaultBinaryMessenger |
a ? is required for me on dart 2.19.6
|
I'm sorry I only tested on the new dart3. So I don't know if it's also ok with other versions. |
|
according to issue #99 I added a namespace |
hatch01
force-pushed
the
main
branch
2 times, most recently
from
655e1ac
to
1808db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just updated de win32 dependencies because it makes the package incompatible with some other packages.
The dart analysis warned up some issues minor issues that I fixed at the same time.