Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return signout response from signoutCallback #1681

Conversation

dopry
Copy link
Contributor

@dopry dopry commented Sep 28, 2024

this is a backport to the 2.4.x series of #1672, but a branch doesn't exist for me to open a PR against.

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@pamapa
Copy link
Member

pamapa commented Sep 30, 2024

created release/v2 branch for backports

@pamapa pamapa added this to the 2.4.1 milestone Sep 30, 2024
@dopry dopry changed the base branch from main to release/v2 October 1, 2024 12:59
@dopry
Copy link
Contributor Author

dopry commented Oct 1, 2024

@pamapa thanks!

@pamapa
Copy link
Member

pamapa commented Oct 2, 2024

please rebase against release/v2 latest, the CI did not trigger, which i have fixed now #1686

@dopry dopry force-pushed the fix/2.4.x-signoutCallback-does-not-return-state branch from 51cba7c to cbc4a91 Compare October 2, 2024 17:36
@dopry
Copy link
Contributor Author

dopry commented Oct 2, 2024

@pamapa done!

@dopry dopry force-pushed the fix/2.4.x-signoutCallback-does-not-return-state branch 2 times, most recently from e81ae5c to b579396 Compare October 2, 2024 17:45
@pamapa pamapa merged commit d94be14 into authts:release/v2 Oct 3, 2024
2 checks passed
@pamapa
Copy link
Member

pamapa commented Oct 3, 2024

thanks for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants