Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal, reproducible example with Keycloak #1208

Closed
zach-betz-hln opened this issue Apr 19, 2024 · 7 comments
Closed

Minimal, reproducible example with Keycloak #1208

zach-betz-hln opened this issue Apr 19, 2024 · 7 comments

Comments

@zach-betz-hln
Copy link

zach-betz-hln commented Apr 19, 2024

This is not an issue.

Just sharing this little project, in hopes that others may play with it and get ideas for their own implementations.

Thank you for this library.

Feel free to close this issue at your convenience.

https://github.com/zach-betz-hln/mre-keycloak-react

@pamapa
Copy link
Member

pamapa commented Apr 22, 2024

This is awesome, thanks for sharing!
I could clone the project as sample-react-oidc-context-keycloak within authts if you want...

@zach-betz-hln
Copy link
Author

@pamapa Sure 👍

@pamapa
Copy link
Member

pamapa commented Apr 22, 2024

Here you go: https://github.com/authts/sample-keycloak-react-oidc-context
Feel free to make pull requests. Would be nice if you keep maintaining it...

zach-betz-hln added a commit to zach-betz-hln/mre-keycloak-react that referenced this issue Apr 22, 2024
@zach-betz-hln
Copy link
Author

I don't like the idea of maintaining duplicate repos, so I've archived my repo and added a link to the one you cloned under the authts namespace. See zach-betz-hln/mre-keycloak-react@07b75ff

@zach-betz-hln
Copy link
Author

@pamapa looks like I need permission to push:

ERROR: Permission to authts/sample-keycloak-react-oidc-context.git denied to zach-betz-hln.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@pamapa
Copy link
Member

pamapa commented Apr 22, 2024

You should have now direct access to the new repository, however everything must go through a pull request, no shortcuts via push :-). This ensures the CI is working, thus for others is also working...

@zach-betz-hln
Copy link
Author

zach-betz-hln commented Apr 22, 2024

Thanks. And yep, the pull request process sounds good to me. See first one: authts/sample-keycloak-react-oidc-context#2

edit: first pr for me, saw you already added ci workflow in authts/sample-keycloak-react-oidc-context#1 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants