generate code for caveat API changes #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
force-pushed
the
generate-caveats
branch
7 times, most recently
from
1dc11b2 to
c141055
Compare
vroldanbet
force-pushed
the
generate-caveats
branch
from
c141055 to
a554327
Compare
| func randString(length int) string { | ||
| b := make([]rune, length) | ||
| for i := range b { | ||
| b[i] = randInput[rand.Intn(len(randInput))] //nolint:gosec |
There was a problem hiding this comment.
Using randoms in tests can cause issues; I'd rather pre-generate a bunch of values
There was a problem hiding this comment.
After discussion, this is fine, since it approximates context usage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking: authzed/spicedb#386
Part of authzed/spicedb#836
Generates changes for authzed/api#38
See https://buf.build/authzed/api/docs/2cfa6639cc8bfd8f4c420758d2b92280b480bf82