Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify how to connect to non-TLS SpiceDB #31

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Nov 24, 2022

some community members struggled to get the example to work because they assumed removing useTransportSecurity() will fallback to usePlaintext() but that's no the case and needs to be added explicitly.

some community members struggled to get
the example to work because they assumed
removing `useTransportSecurity()` will fallback
to `usePlaintext()` but that's no the case and
needs to be added explicitly.
@vroldanbet vroldanbet requested a review from a team November 24, 2022 10:19
@vroldanbet vroldanbet self-assigned this Nov 24, 2022
@vroldanbet vroldanbet requested a review from samkim December 1, 2022 10:49
@vroldanbet
Copy link
Contributor Author

Hey @samkim, this is quick doc updated, mind having a look? 🙏🏻

Copy link
Member

@samkim samkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samkim samkim merged commit 86a4b69 into main Dec 28, 2022
@samkim samkim deleted the add-clarifying-comment-to-example branch December 28, 2022 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants