Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protoc and gRPC versions for generated code #99

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Aug 27, 2024

Depends on grpc/grpc-java#11015

Description

A customer noted a deprecation warning that they got when pulling in this library:

* @deprecated This class is deprecated, and slated for removal in the next Java breaking change
*     (5.x). Users should update gencode to >= 4.26.x which uses GeneratedMessage instead.
*/

@Deprecated
public abstract class GeneratedMessageV3
    extends GeneratedMessage.ExtendableMessage<GeneratedMessageV3> {

When I went and dug into it, we're currently on v25 of protobuf which corresponds to v3.25.x of the java protoc tooling. We want to be on v27, which is the currently-supported version.

There's more information in the support matrix here: https://protobuf.dev/support/version-support/#java

Note

There are breaking changes in the v26 release, which is a version boundary that we're crossing. It seems like most of the changes are related to features of the generated code that most consumers won't be using or aware of, but it may be prudent to make this a major version bump.

Changes

  • Bump the version of the protoc plugin we're using
  • Bump the gRPC version that we pull in

Testing

Review. See that things are green.

@tstirrat15 tstirrat15 requested a review from a team August 27, 2024 18:37
@tstirrat15
Copy link
Contributor Author

The builds are still failing - it seems like there are some wires getting crossed around which version of protobuf-java is being used, but I can't figure out the right combination. Gonna come back to this.

@tstirrat15
Copy link
Contributor Author

I think this is blocked behind the resolution of grpc/grpc-java#11015 (comment)

@tstirrat15 tstirrat15 added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit edf094d Sep 5, 2024
14 checks passed
@tstirrat15 tstirrat15 deleted the bump-build-dep-versions branch September 5, 2024 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants