Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #120

Closed
wants to merge 1 commit into from
Closed

Fix unit tests #120

wants to merge 1 commit into from

Conversation

alecmerdler
Copy link
Contributor

Updates the unit tests so that async/await is not used with the done callback.

Also aligns the tests for the callback client to only use the done callback-style tests rather than promises, which clarifies the usage of the client.

Updates the unit tests so that async/await is not used with
the 'done' callback.

Also aligns the tests for the callback client to only use the
'done' callback-style tests rather than promises, which clarifies
the usage of the client.
@alecmerdler alecmerdler self-assigned this Jun 3, 2024
@alecmerdler alecmerdler requested a review from a team as a code owner June 3, 2024 19:26
Copy link

github-actions bot commented Jun 3, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@alecmerdler
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

authzedbot added a commit to authzed/cla that referenced this pull request Jun 3, 2024
@alecmerdler
Copy link
Contributor Author

Closing in favor of #119

@alecmerdler alecmerdler closed this Jun 3, 2024
@alecmerdler alecmerdler deleted the fix-tests branch June 3, 2024 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant