Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly wire up experimental service #100

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Oct 16, 2023

Closes #101

There is a little bit of manual plumbing required in order to expose new gRPC services via Client. The ExperimentalService and WatchService seem to have been overlooked. This PR updates Client to expose those service API methods.

It also adds examples and tests for BulkCheckPermission, BulkImportRelationships and BulkExportRelationships.
Python version testing matrix was also updated up to 3.11 and removed EOL versions. 3.12 didn't work out of the box, so it shall be addressed in a follow up.

@vroldanbet vroldanbet force-pushed the wire-up-experimental-service branch 2 times, most recently from c8c89a0 to 395cd5a Compare October 16, 2023 09:09
- removes the unimplemented StreamingBulkCheckPermission API
- increases Schema size to 4MB
@vroldanbet vroldanbet force-pushed the wire-up-experimental-service branch 2 times, most recently from c726734 to 853aab3 Compare October 16, 2023 10:08
- 3.7 is EOL
- 3.11 and 3.12 got released

there is an error when importing dependencies
in 3.12, so I've excluded it for now
@vroldanbet vroldanbet marked this pull request as ready for review October 16, 2023 10:13
@vroldanbet vroldanbet requested a review from a team October 16, 2023 10:13
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet merged commit 83209e4 into main Oct 16, 2023
12 checks passed
@vroldanbet vroldanbet deleted the wire-up-experimental-service branch October 16, 2023 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose experimental services in Client
3 participants