-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly wire up experimental service #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
force-pushed
the
wire-up-experimental-service
branch
2 times, most recently
from
October 16, 2023 09:09
c8c89a0
to
395cd5a
Compare
- removes the unimplemented StreamingBulkCheckPermission API - increases Schema size to 4MB
vroldanbet
force-pushed
the
wire-up-experimental-service
branch
2 times, most recently
from
October 16, 2023 10:08
c726734
to
853aab3
Compare
- 3.7 is EOL - 3.11 and 3.12 got released there is an error when importing dependencies in 3.12, so I've excluded it for now
vroldanbet
force-pushed
the
wire-up-experimental-service
branch
from
October 16, 2023 10:09
d53bd9d
to
f395551
Compare
jurecuhalev
reviewed
Oct 16, 2023
josephschorr
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101
There is a little bit of manual plumbing required in order to expose new gRPC services via
Client
. TheExperimentalService
andWatchService
seem to have been overlooked. This PR updatesClient
to expose those service API methods.It also adds examples and tests for
BulkCheckPermission
,BulkImportRelationships
andBulkExportRelationships
.Python version testing matrix was also updated up to 3.11 and removed EOL versions. 3.12 didn't work out of the box, so it shall be addressed in a follow up.