Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was something I ran across when trying to get the python client build stood up on my local. The old buf.gen.yaml required you to have various protoc plugin binaries installed in places that buf expected, and I couldn't figure out which versions from which packages provided the correct binaries.
Since we originally set up
buf.gen.yaml
, they've released a v2 of buf and its configuration, and one of the things that this allows for is using remote versions of the plugins, where buf takes care of the work of providing the protoc plugin binary and this is abstracted away from the user.It's definitely a nicer DX. My only concern is about integrating it into our build processes, and whether we consider this to be more concerning from a supply-chain perspective than manually downloading and setting up the protoc plugins.
I also am not entirely sure that the new plugins line up with the old; the new version of the config file uses a pyi plugin instead of the pair of mypy plugins. We can talk about whether that's desired.
Changes
Testing
Review.