Bump API version and fix automatic bumping #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
changed the title
vroldanbet
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
LGTM! This PR supersedes the automatically opened #137, right?
| @@ -1,9 +1,9 @@ | |||
| #!/usr/bin/env -S buf generate --template | |||
There was a problem hiding this comment.
tested locally with buf generate and got the same output 👍🏻
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gets the lib on 1.38. Also changes how generation is done.
Changes
See annotations
Testing
See that things go green.