Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting broken if object type is namespaced with / #19

Closed
alechenninger opened this issue Jul 19, 2024 · 5 comments · Fixed by #26
Closed

Syntax highlighting broken if object type is namespaced with / #19

alechenninger opened this issue Jul 19, 2024 · 5 comments · Fixed by #26

Comments

@alechenninger
Copy link

See screenshot:

image
@tstirrat15
Copy link
Collaborator

I'm curious whether fixing #20 by bumping the version will also fix this.

@h3adache
Copy link
Contributor

h3adache commented Jan 9, 2025

It appears not. I'm running 1.0.1 and see the same issue with prefixed definitions.

@tstirrat15
Copy link
Collaborator

I'll have a look.

@h3adache h3adache mentioned this issue Jan 10, 2025
Merged
@h3adache
Copy link
Contributor

Thanks @tstirrat15! I found the cause. It's not matching the definition grammar fully so it's not expecting prefixed definitions. I only fixed the one for definitions even though several others have the same issue they don't seem to be affecting anything.

Not able to click navigate arrow permissions atm but that is not handled through this.

@tstirrat15
Copy link
Collaborator

I've published this in v1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix definition grammar h3adache/spicedb-vscode
3 participants
@h3adache @tstirrat15 @alechenninger