Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP not parsing .all() syntax #20

Closed
mateenkasim opened this issue Oct 7, 2024 · 9 comments
Closed

LSP not parsing .all() syntax #20

mateenkasim opened this issue Oct 7, 2024 · 9 comments
Labels
kind/bug Something is broken or regressed

Comments

@mateenkasim
Copy link

What platforms are affected?

macos

What architectures are affected?

arm64

What SpiceDB version are you using?

Latest version of the VSCode extension, 0.0.7: https://marketplace.visualstudio.com/items?itemName=authzed.spicedb-vscode

Steps to Reproduce

Just following https://authzed.com/docs/spicedb/concepts/schema#all-intersection-arrow:

definition file {
  relation project: project

  permission access = project.all(access)
}

Expected Result

Validates properly

Actual Result

image
@mateenkasim mateenkasim added the kind/bug Something is broken or regressed label Oct 7, 2024
@tstirrat15
Copy link
Collaborator

I'm gonna transfer this to the spicedb-vscode repo.

@tstirrat15 tstirrat15 transferred this issue from authzed/spicedb Oct 8, 2024
@tstirrat15
Copy link
Collaborator

I'm at an offsite right now but I'll take a look at this soon.

@tstirrat15
Copy link
Collaborator

It should be sufficient to update the version in download-wasm and regenerate.

@tstirrat15
Copy link
Collaborator

@mateenkasim
Copy link
Author

Unfortunately it did not :/

Also fyi, I got this warning when updating:
image

@tstirrat15
Copy link
Collaborator

@mateenkasim thank you for checking! I'll look into that on monday.

@tstirrat15
Copy link
Collaborator

@mateenkasim I realized that the issue you're running into is because the extension uses the SpiceDB binary for its LSP. Upgrading your system's SpiceDB binary should resolve your issue.

I also figured out that we were able to simplify our publishing steps, so I'm going to cut a new release and see if that helps with the package signature problem.

@mateenkasim
Copy link
Author

Whoops, silly mistake, thanks for the pointer. That fixed my issue, and the new release fixed the signature problem!

Thanks for your help! 🙏

@tstirrat15
Copy link
Collaborator

Awesome. Glad to hear it! And it was non-obvious to me too :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something is broken or regressed
Projects
None yet
Development

No branches or pull requests

2 participants