Ensure e2e doesn't time out when it would have succeeded #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
ecordell
force-pushed
the
e2e-timeout
branch
7 times, most recently
from
f005b8e to
6939e5b
Compare
Signed-off-by: Evan Cordell <cordell.evan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the network delay added for the newenemy test, sometimes the number of required successful iterations exceeded the timeout. This change makes the timeout depend on the number of iterations picked.
I also adjusted the constants to try to improve the worst-case runtime, and marked the artifact upload step to not fail the job if it fails (since it has a surprisingly high failure rate).