Add a datastore repair command for revisions from Postgres backups
#1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
josephschorr
force-pushed
the
pg-repair-revs
branch
2 times, most recently
from
4fbe949 to
97dbb51
Compare
vroldanbet
reviewed
Nov 10, 2023
| Short: "executes datastore repair", | ||
| Long: "Executes a repair operation for the datastore", | ||
| PreRunE: server.DefaultPreRunE(programName), | ||
| RunE: termination.PublishError(func(cmd *cobra.Command, args []string) error { |
There was a problem hiding this comment.
can we refactor this into a new function and add basic unit tests?
There was a problem hiding this comment.
For... printing and invoking a function?
There was a problem hiding this comment.
the cmd package does not have good test coverage, and I observed regressions specifically around configuration change. This function does not have configuration going on. I still think that commands deserve test coverage too, but I leave that up to you
josephschorr
force-pushed
the
pg-repair-revs
branch
from
97dbb51 to
31d4598
Compare
vroldanbet
previously approved these changes
Nov 14, 2023
josephschorr
force-pushed
the
pg-repair-revs
branch
from
31d4598 to
214aa59
Compare
vroldanbet
previously approved these changes
Nov 15, 2023
josephschorr
force-pushed
the
pg-repair-revs
branch
4 times, most recently
from
966140e to
d59ebfb
Compare
vroldanbet
previously approved these changes
Nov 16, 2023
josephschorr
force-pushed
the
pg-repair-revs
branch
from
d59ebfb to
9c9e95e
Compare
josephschorr
force-pushed
the
pg-repair-revs
branch
from
9c9e95e to
8661bf2
Compare
vroldanbet
approved these changes
Nov 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1630