Ensure debug information is returned for recursive checks that dispatch #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
josephschorr
force-pushed
the
check-recurse-error
branch
from
ca65ae2 to
b05fd3c
Compare
josephschorr
force-pushed
the
check-recurse-error
branch
from
b05fd3c to
103663e
Compare
ecordell
reviewed
Aug 12, 2024
| @@ -340,6 +341,19 @@ func distinguishGraphError(ctx context.Context, dispatchError error, source devi | |||
| }, nil | |||
| } | |||
|
|
|||
| details, ok := spiceerrors.GetDetails[*errdetails.ErrorInfo](dispatchError) | |||
There was a problem hiding this comment.
why doesn't the previous case handle this?
There was a problem hiding this comment.
Because the previous case is a non-gRPC wrapped error from the local dispatch vs a gRPC error from a remote dispatch
ecordell
approved these changes
Aug 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.