Have diffexpr handle the case of adding to a single child expression #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this still doesn't apply for exclusions, and they have a different expression tree format
github-actions
bot
added
the
area/tooling
vroldanbet
reviewed
Aug 26, 2024
Co-authored-by: Víctor Roldán Betancort <vroldanbet@users.noreply.github.com>
vroldanbet
approved these changes
Aug 30, 2024
| // If the expression has changed from a union with a single child, then | ||
| // treat this as a special case, since there wasn't really an operation | ||
| // before. | ||
| if existingType != "union" || len(existingOperation.Child) != 1 { |
There was a problem hiding this comment.
why not returning expanded with intersections and exclusions too?
There was a problem hiding this comment.
We don't create intersections/exclusions with a single child. Only union because we needed some operation to place there during compilation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this still doesn't apply for exclusions, and they have a different expression tree format