Implement non-experimental bulk import and export #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
tstirrat15
force-pushed
the
implement-import-export-bulk-server
branch
from
143006f to
43189cb
Compare
tstirrat15
commented
Sep 17, 2024
| @@ -101,8 +102,7 @@ func NewExperimentalServer(dispatch dispatch.Dispatcher, permServerConfig Permis | |||
| streamtimeout.MustStreamServerInterceptor(config.StreamReadTimeout), | |||
| ), | |||
| }, | |||
| defaultBatchSize: uint64(config.DefaultExportBatchSize), | |||
There was a problem hiding this comment.
This wasn't in use anywhere i could find
tstirrat15
force-pushed
the
implement-import-export-bulk-server
branch
from
45e8d7a to
40bc64a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of moving bulk import and export out of experimental. This PR takes a copy-paste approach with cleanup to be done in future work.
Changes
Testing
Review. See that tests pass.