Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using yaml anchors in release action configuration #2071

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Stop using yaml anchors in release action configuration #2071

merged 1 commit into from
Sep 19, 2024

Conversation

tstirrat15
Copy link
Contributor

Relates to authzed/zed#419

Description

Turns out github actions don't support yaml anchors: actions/runner#1182

This would have been a problem when we cut a release.

Changes

  • Get rid of yaml anchor syntax

Testing

Review. Cut a release and see that it succeeds.

@tstirrat15 tstirrat15 requested a review from a team as a code owner September 19, 2024 15:42
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Sep 19, 2024
@tstirrat15 tstirrat15 added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit f813abe Sep 19, 2024
22 checks passed
@tstirrat15 tstirrat15 deleted the stop-using-yaml-anchors branch September 19, 2024 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

Assignees
No one assigned
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstirrat15 @vroldanbet