Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LRv2 by default and update the steelthread tests #2079

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

josephschorr
Copy link
Member

The steelthread tests have to be updated because the "indirect" tests now return results in a slightly different order in LRv2. Manually verified that the results themselves are the same (except duplicates, which are allowed)

The steelthread tests have to be updated because the "indirect" tests now return results in a slightly different order in LRv2. Manually verified that the results themselves are the same (except duplicates, which are allowed)
@josephschorr josephschorr requested a review from a team September 25, 2024 17:01
@github-actions github-actions bot added the area/CLI Affects the command line label Sep 25, 2024
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr added this pull request to the merge queue Sep 25, 2024
Merged via the queue into authzed:main with commit 89dcca1 Sep 25, 2024
22 checks passed
@josephschorr josephschorr deleted the enable-lr2-default branch September 25, 2024 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/CLI Affects the command line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants