metrics: spicedb_environment_info from telemetry #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reuses the logic for spicedb_telemetry_info for a metric registered to the default Prometheus registry.
jzelinskie
added
area/observability
vroldanbet
reviewed
Oct 17, 2024
| @@ -57,9 +50,42 @@ func RegisterTelemetryCollector(datastoreEngine string, ds datastore.Datastore) | |||
| "arch": runtime.GOARCH, | |||
| "go": buildInfo.GoVersion, | |||
There was a problem hiding this comment.
we are already providing go version through the standard Go extended runtime metrics. It's available through go_info
There was a problem hiding this comment.
Yeah, this is an artifact of reusing the same metric across telemetry and non-telemetry usage. Should I make it optional or just keep it?
There was a problem hiding this comment.
it's ok, I don't think it hurts, just wanted to call it out
Co-authored-by: Víctor Roldán Betancort <vroldanbet@users.noreply.github.com>
vroldanbet
approved these changes
Oct 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reuses the logic for
spicedb_telemetry_infofor a metric registered to the default Prometheus registry.Fixes #2086