Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy old schema package into new package #2101

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

tstirrat15
Copy link
Contributor

Description

The first part of implementing composable schemas. We decided that we want to create a new package and build on top of it while development is in flight. Doing the copying as a separate PR means that the first PR where meaningful changes happen will have a meaningful diff.

Changes

  • Copy old schema package into new package
  • Update import references to point at new package

Testing

See that things are green

@tstirrat15 tstirrat15 requested a review from a team October 24, 2024 20:32
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Oct 24, 2024
@tstirrat15 tstirrat15 force-pushed the add-new-schema-package branch from 2405774 to 371405c Compare October 24, 2024 20:37
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this happened after a discussion with @josephschorr that this is the route we want to take?

Personally I'm not convinced that this is the best plan; we know we have some schema feature work coming up and we'll have to make them in two places now.

I won't block it if you have consensus on this approach though.

@josephschorr
Copy link
Member

@ecordell Yes, this is the preferred approach. While we'll have to copy the changes into both packages, they will diverge fairly soon and until we have an IR for schema, we can't break back-compat with the existing schema parser. Adding conditionals into the existing parser will be quite ugly too, so I figured this was a better solution, even if it does require a bit more work upfront

@tstirrat15 tstirrat15 added this pull request to the merge queue Oct 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2024
@tstirrat15 tstirrat15 added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit c11aac6 Oct 25, 2024
22 checks passed
@tstirrat15 tstirrat15 deleted the add-new-schema-package branch October 25, 2024 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants