Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable native histograms in server latency metrics #2102

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

bison
Copy link
Member

@bison bison commented Oct 25, 2024

Enables Native Histograms for gRPC server metrics.

As far as I know, there's not really a reason to not enable this. Clients that don't support it will still get the same format they always have. We should do some more thorough research and confirm that though.

@bison bison requested a review from a team October 25, 2024 17:24
@github-actions github-actions bot added the area/CLI Affects the command line label Oct 25, 2024
alecmerdler
alecmerdler previously approved these changes Oct 25, 2024
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this would enable native histograms only for the gRPC prometheus middleware, which I think is great but ideally we enable it for each histogram in the application

@josephschorr josephschorr added this pull request to the merge queue Nov 1, 2024
Merged via the queue into authzed:main with commit 51edc2d Nov 1, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@bison bison deleted the native-histograms branch December 5, 2024 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/CLI Affects the command line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants