Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relationtuple stringifying function #2112

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add relationtuple stringifying function #2112

merged 2 commits into from
Oct 30, 2024

Conversation

tstirrat15
Copy link
Contributor

Description

Adding some utility fns to stringify v1.RelationTuples

Changes

  • Add stringification functions
  • Add some tests

Testing

Review

@tstirrat15 tstirrat15 requested a review from a team October 30, 2024 20:32
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Oct 30, 2024
josephschorr
josephschorr approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstirrat15 tstirrat15 force-pushed the add-relation-stringifying-function branch from fa8fb33 to 1226581 Compare October 30, 2024 20:37
@tstirrat15 tstirrat15 enabled auto-merge October 30, 2024 20:37
@tstirrat15 tstirrat15 force-pushed the add-relation-stringifying-function branch from 1226581 to b902aae Compare October 30, 2024 20:44
@tstirrat15 tstirrat15 added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@tstirrat15 tstirrat15 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 595bb46 Oct 30, 2024
22 checks passed
@tstirrat15 tstirrat15 deleted the add-relation-stringifying-function branch October 30, 2024 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees
No one assigned
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstirrat15 @josephschorr