Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduces ByteSortable method in Revision #2125

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

vroldanbet
Copy link
Contributor

This helps determine if the string representation
of the revision is byte-sortable. This helps
being able to determine if a revision can be
serialized to databases that rely on byte-sorting.

@vroldanbet vroldanbet requested a review from a team November 8, 2024 10:41
@github-actions github-actions bot added the area/datastore Affects the storage system label Nov 8, 2024
@vroldanbet vroldanbet enabled auto-merge November 8, 2024 10:42
pkg/datastore/datastore.go Outdated Show resolved Hide resolved
@vroldanbet vroldanbet force-pushed the byte-sortable-revision branch from 352ea41 to bc973ba Compare November 12, 2024 15:31
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Nov 12, 2024
This helps determine if the string representation
of the revision is byte-sortable. This helps
being able to determine if a revision can be
serialized to databases that rely on byte-sorting.
@vroldanbet vroldanbet force-pushed the byte-sortable-revision branch from bc973ba to bc265a8 Compare November 12, 2024 15:33
@vroldanbet vroldanbet added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@vroldanbet vroldanbet added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 0ee32ac Nov 12, 2024
22 checks passed
@vroldanbet vroldanbet deleted the byte-sortable-revision branch November 12, 2024 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants