Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: schema watch causes incorrect delete event for schema changes #2149

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix: schema watch causes incorrect delete event for schema changes #2149

merged 2 commits into from
Nov 29, 2024

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Nov 29, 2024 •
edited
Loading

the computation of schema change events was incorrect due to
the use of the wrong snapshot XID for changed namespaces / caveats.
It manifested itself as a change event, followed by a delete event.

@vroldanbet
repro: namespace/caveat changes cause an incorrect delete event
a5e5087
@vroldanbet
fix: namespace/caveat changes cause an incorrect delete event
369286e 
the computation of schema change events was incorrect due to
the use of the wrong snapshot XID for changed namespaces / caveats.
It manifested itself as a change event, followed by a delete event.
@vroldanbet vroldanbet requested a review from a team as a code owner November 29, 2024 15:42
@vroldanbet vroldanbet self-assigned this Nov 29, 2024
@github-actions github-actions bot added the area/datastore Affects the storage system label Nov 29, 2024
@vroldanbet vroldanbet enabled auto-merge November 29, 2024 15:51
josephschorr
josephschorr approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@josephschorr josephschorr added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@josephschorr josephschorr added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@vroldanbet vroldanbet added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@vroldanbet vroldanbet added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 91d42d2 Nov 29, 2024
22 checks passed
@vroldanbet vroldanbet deleted the fix-watch-schema-bug branch November 29, 2024 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees

@vroldanbet vroldanbet

Labels
area/datastore Affects the storage system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vroldanbet @josephschorr