Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added magefile target to generate docs #2208

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kartikaysaxena
Copy link
Contributor

Migrated the logic for initialising rootCmd to pkg/cmd in a function which is invoked by a magefile target gen:docs to generate documentation for SpiceDB. Also added a workflow which would detect changes and run the target to generate docs and auto submit the diff the authzed/docs, docs currently at authzed/docs#298

@kartikaysaxena kartikaysaxena requested a review from a team as a code owner January 20, 2025 18:00
@github-actions github-actions bot added area/CLI Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Jan 20, 2025
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
)

replace github.com/authzed/spicedb => ../
Copy link
Contributor Author

@kartikaysaxena kartikaysaxena Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this otherwise the magefile would have broken for now as I used go get github.com/authzed/spicedb/pkg/cmd which does not use the local package. The lint is also failing because of this reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this is because google.golang.org/protobuf has a dependency of v1.36.1 in spicedb but in magefile it is v1.34.2 so when trying to import the package it resolves the dependency to 1.36.1 and lint:all calls gen:proto which is enforcing the latest version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CLI Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant