Add revision support to v1alpha1 schema API #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
josephschorr
force-pushed
the
schema-revision
branch
3 times, most recently
from
ffcf3c3 to
2812cc4
Compare
jzelinskie
reviewed
Nov 15, 2021
jzelinskie
requested changes
Nov 15, 2021
|
|
||
| rev, err := decodeV1Alpha1Revision(resp.ComputedDefinitionsRevision) | ||
| require.NoError(t, err) | ||
| require.Equal(t, 1, len(rev)) |
There was a problem hiding this comment.
require has a length function for this: require.Len(t, rev, 1)
josephschorr
force-pushed
the
schema-revision
branch
from
2812cc4 to
6e148e4
Compare
|
Updated |
jzelinskie
reviewed
Nov 15, 2021
jzelinskie
reviewed
Nov 15, 2021
josephschorr
force-pushed
the
schema-revision
branch
from
6e148e4 to
cde10f4
Compare
|
Updated |
josephschorr
force-pushed
the
schema-revision
branch
from
cde10f4 to
52caa0d
Compare
Allows for reading a combined revision from ReadSchema, and using the same revision as a precondition to WriteSchema to determine if any of the types have changed since the last read occurred
josephschorr
force-pushed
the
schema-revision
branch
from
e280e29 to
974cf96
Compare
jzelinskie
previously approved these changes
Nov 16, 2021
jzelinskie
approved these changes
Nov 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for reading a combined revision from ReadSchema, and using the same revision as a precondition to WriteSchema to determine if any of the types have changed since the last read occurred