Skip to content

feat: allow underscore prefix for private identifiers #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivanauth wants to merge 6 commits into
base: main
Choose a base branch
from
+172 −93
Open

feat: allow underscore prefix for private identifiers #2733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
835c8e9
docs: document underscore prefix for private identifiers
ivanauth Nov 26, 2025
8005a12
fix: add trailing newline to schema-language.md
ivanauth Nov 26, 2025
a0b215a
chore: remove in-repo docs (should go to authzed/docs)
ivanauth Jan 7, 2026
48c6e78
chore: trigger CI re-run for flaky E2E test
ivanauth Jan 7, 2026
1eb6d4b
ci: re-run tests
ivanauth Jan 8, 2026
7235660
ci: re-run tests (attempt 2)
ivanauth Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/newenemy/newenemy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ definition {{.Resource}} {
{{ end }}
`
objIDRegex = "[a-zA-Z0-9_][a-zA-Z0-9/_-]{0,127}"
namespacePrefixRegex = "[a-z][a-z0-9_]{1,62}[a-z0-9]"
namespacePrefixRegex = "[a-z_][a-z0-9_]{1,62}[a-z0-9]"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions pkg/composableschemadsl/compiler/compiler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ func TestCompile(t *testing.T) {
"invalid definition name",
nilPrefix,
`definition someTenant/fo {}`,
"parse error in `invalid definition name`, line 1, column 1: error in object definition someTenant/fo: invalid NamespaceDefinition.Name: value does not match regex pattern \"^([a-z][a-z0-9_]{1,62}[a-z0-9]/)*[a-z][a-z0-9_]{1,62}[a-z0-9]$\"",
"parse error in `invalid definition name`, line 1, column 1: error in object definition someTenant/fo: invalid NamespaceDefinition.Name: value does not match regex pattern \"^([a-z_][a-z0-9_]{1,62}[a-z0-9]/)*[a-z_][a-z0-9_]{1,62}[a-z0-9]$\"",
[]SchemaDefinition{},
},
{
Expand All @@ -778,7 +778,7 @@ func TestCompile(t *testing.T) {
`definition some_tenant/foos {
relation ab: some_tenant/foos
}`,
"parse error in `invalid relation name`, line 2, column 5: error in relation ab: invalid Relation.Name: value does not match regex pattern \"^[a-z][a-z0-9_]{1,62}[a-z0-9]$\"",
"parse error in `invalid relation name`, line 2, column 5: error in relation ab: invalid Relation.Name: value does not match regex pattern \"^[a-z_][a-z0-9_]{1,62}[a-z0-9]$\"",
[]SchemaDefinition{},
},
{
Expand Down
2 changes: 1 addition & 1 deletion pkg/development/wasm/operations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func TestCheckOperation(t *testing.T) {
tuple.MustParse("somenamespace:someobj#anotherrel@user:foo"),
nil,
&devinterface.DeveloperError{
Message: "error in object definition fo: invalid NamespaceDefinition.Name: value does not match regex pattern \"^([a-z][a-z0-9_]{1,62}[a-z0-9]/)*[a-z][a-z0-9_]{1,62}[a-z0-9]$\"",
Message: "error in object definition fo: invalid NamespaceDefinition.Name: value does not match regex pattern \"^([a-z_][a-z0-9_]{1,62}[a-z0-9]/)*[a-z_][a-z0-9_]{1,62}[a-z0-9]$\"",
Kind: devinterface.DeveloperError_SCHEMA_ISSUE,
Source: devinterface.DeveloperError_SCHEMA,
Line: 1,
Expand Down
78 changes: 39 additions & 39 deletions pkg/proto/core/v1/core.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading