test: Set up integration testing to finish implementation of the iterator tree functionality #2787
+286
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2787 +/- ##
==========================================
- Coverage 78.50% 78.47% -0.02%
==========================================
Files 458 458
Lines 44253 44277 +24
==========================================
+ Hits 34736 34744 +8
- Misses 6698 6708 +10
- Partials 2819 2825 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
barakmich
force-pushed
the
barakmich/finish_iters
branch
2 times, most recently
from
ae4de81 to
760f55e
Compare
barakmich
force-pushed
the
barakmich/finish_iters
branch
from
760f55e to
1f7e267
Compare
tstirrat15
approved these changes
Jan 7, 2026
Contributor
tstirrat15
left a comment
tstirrat15
left a comment
There was a problem hiding this comment.
See comments, otherwise LGTM
|
|
||
| // Test SubjectTypes - should return all defined subject types | ||
| subjectTypes := accessibilitySet.SubjectTypes() | ||
| require.NotEmpty(subjectTypes) |
Contributor
There was a problem hiding this comment.
Can we make a stronger assertion here?
| resources := accessibilitySet.AllResourcesNoWildcards() | ||
| require.NotEmpty(resources) | ||
|
|
||
| // Test UncomputedPermissionshipFor and AccessibiliyAndPermissionshipFor |
Contributor
There was a problem hiding this comment.
I'm renaming AccessibiliyAndPermissionshipFor in the PR that I'm working on - it may make sense to do it in this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically,
IterSubjectsandIterResources(equivalent to LS, LR)Description
Testing
References