-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use consistent-hash load balancer with kubernetes resolver for dispatch #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
changed the title
use consistent-hash load balancer with kubernetes endpoint resolver for
use consistent-hash load balancer with kubernetes resolver for dispatch
Nov 12, 2021
ecordell
force-pushed
the
consistent-lb
branch
3 times, most recently
from
November 12, 2021 20:18
ab98b09
to
c7610af
Compare
ecordell
added
area/dispatch
Affects dispatching of requests
area/CLI
Affects the command line
area/perf
Affects performance or scalability
labels
Nov 12, 2021
ecordell
force-pushed
the
consistent-lb
branch
from
November 12, 2021 20:32
c7610af
to
d4915d8
Compare
jakedt
requested changes
Nov 12, 2021
ecordell
force-pushed
the
consistent-lb
branch
2 times, most recently
from
November 12, 2021 20:48
24f15c7
to
3a16b78
Compare
@jakedt also bumped the replicationFactor to a |
ecordell
force-pushed
the
consistent-lb
branch
from
November 12, 2021 20:55
778f066
to
5d4a7f9
Compare
github-actions
bot
added
the
area/tooling
Affects the dev or user toolchain (e.g. tests, ci, build tools)
label
Nov 12, 2021
jakedt
requested changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is more servok-related code that we can kill now, right?
ecordell
force-pushed
the
consistent-lb
branch
2 times, most recently
from
November 12, 2021 22:03
24da454
to
416bf07
Compare
ecordell
force-pushed
the
consistent-lb
branch
from
November 12, 2021 22:05
416bf07
to
ca1c913
Compare
jakedt
requested changes
Nov 12, 2021
jzelinskie
reviewed
Nov 14, 2021
ecordell
force-pushed
the
consistent-lb
branch
from
November 15, 2021 14:54
ca1c913
to
c155d1a
Compare
ecordell
force-pushed
the
consistent-lb
branch
from
November 15, 2021 15:49
0b281b1
to
2020b48
Compare
jakedt
previously approved these changes
Nov 15, 2021
ecordell
force-pushed
the
consistent-lb
branch
3 times, most recently
from
November 15, 2021 17:08
b6d5e11
to
ed9956a
Compare
ecordell
force-pushed
the
consistent-lb
branch
from
November 15, 2021 17:14
ed9956a
to
2fa4b08
Compare
jakedt
approved these changes
Nov 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/CLI
Affects the command line
area/dependencies
Affects dependencies
area/dispatch
Affects dispatching of requests
area/perf
Affects performance or scalability
area/tooling
Affects the dev or user toolchain (e.g. tests, ci, build tools)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag
--dispatch-upstream-addr
and optional--dispatch-upstream-ca-path
If set, spicedb will use the new consistent hash loadbalancer (which is just the existing consistent hashring, wired into grpc-go) to pick endpoints for a dispatch request. This is an alternative to configuring a client to watch the a Dispatch API provider like servok.
This also adds support for using the
kubernetes
name resolver strategy provided by kuberesolver.Example:
spicedb serve --grpc-preshared-key "somerandomkeyhere" --dispatch-upstream-addr=kubernetes://spicedb.dev:50053