increase max offset for crdb cluster in e2e tests #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analyzing recent e2e flakes suggested that:
I bumped the
max-offset
for the cluster which should prevent crdb nodes from being marked bad even with the offsets we use to demonstrate the new enemy problem.I also reduced the amount of data that the test writes - it was overly aggressive before just because (at the time) it was still faster than the other test suites. This should™️ prevent the test from stalling out on writing filler data.
I re-ran e2e twice on this PR after these changes and both times they converged very quickly.