Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a non-caching namespace manager #423

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Conversation

ecordell
Copy link
Contributor

this allows certain operations to deal with non-persisted namespaces
with the same interface as persisted namespaces

@github-actions github-actions bot added area/api v0 Affects the v0 API area/api v1 Affects the v1 API labels Feb 18, 2022
@ecordell ecordell marked this pull request as ready for review February 18, 2022 15:19
@github-actions github-actions bot added area/CLI Affects the command line area/dispatch Affects dispatching of requests area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Feb 18, 2022
@ecordell ecordell force-pushed the nocachensm branch 3 times, most recently from 1d926f7 to 0421ace Compare February 22, 2022 18:59
@ecordell ecordell enabled auto-merge February 22, 2022 19:00
require.NoError(t, err)
require.Equal(t, "test/user", defB.Name)

require.Equal(t, def, defB)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add another write and make sure it immediately updates

this allows certain operations to deal with non-persisted namespaces
with the same interface as persisted namespaces
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit e35a32c into authzed:main Feb 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api v0 Affects the v0 API area/api v1 Affects the v1 API area/CLI Affects the command line area/dispatch Affects dispatching of requests area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants