Add middleware to return the server version when requested, unless disabled #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
josephschorr
force-pushed
the
server-version
branch
2 times, most recently
from
a042362 to
46195fa
Compare
Comment on lines
72
to
73
| // Flags for misc services | ||
| util.RegisterHTTPServerFlags(cmd.Flags(), &config.DashboardAPI, "dashboard", "dashboard", ":8080", true) |
There was a problem hiding this comment.
why are we using two dashboard key inside a flag
There was a problem hiding this comment.
One is the flag prefix, the other is the service name
jzelinskie
previously approved these changes
May 3, 2022
josephschorr
force-pushed
the
server-version
branch
from
46195fa to
ce31c0e
Compare
josephschorr
force-pushed
the
server-version
branch
from
ce31c0e to
56c3b4d
Compare
jzelinskie
approved these changes
May 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.