Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement revision quantization for MySQL #582

Merged
merged 9 commits into from
May 4, 2022
Merged

Implement revision quantization for MySQL #582

merged 9 commits into from
May 4, 2022

Conversation

bryanhuhta
Copy link
Contributor

This PR implements the cached revision quantization optimization for the MySQL driver. We attempted to stay as true to the Postgres implementation as possible.

See also:

@cjs
Implement revision quantization for MySQL
6ca4e40 
Co-authored-by: Craig Steinberger <cjs@github.com>
@bryanhuhta bryanhuhta requested a review from vroldanbet as a code owner May 2, 2022 18:04
@bryanhuhta bryanhuhta requested a review from a team May 2, 2022 18:04
@github-actions github-actions bot added area/CLI Affects the command line area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels May 2, 2022
ecordell
ecordell requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I had a few comments about some (unlikely) overflows, but this does appear to quantize the same way as postgres now 👍

pkg/cmd/datastore/datastore.go Outdated Show resolved Hide resolved
internal/datastore/mysql/revisions.go Outdated Show resolved Hide resolved
internal/datastore/mysql/revisions.go Outdated Show resolved Hide resolved
internal/datastore/mysql/revisions.go Show resolved Hide resolved
internal/datastore/mysql/revisions.go Outdated Show resolved Hide resolved
internal/datastore/mysql/revisions.go Show resolved Hide resolved
internal/datastore/mysql/datastore_test.go Outdated Show resolved Hide resolved
@ecordell ecordell mentioned this pull request May 3, 2022
Merged
ecordell
ecordell approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell enabled auto-merge May 4, 2022 19:38
@ecordell ecordell merged commit 2fe0a05 into authzed:main May 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2022
@bryanhuhta bryanhuhta deleted the mysql-revision-quantization branch May 4, 2022 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ecordell ecordell ecordell approved these changes

@vroldanbet vroldanbet Awaiting requested review from vroldanbet vroldanbet is a code owner

Assignees
No one assigned
Labels
area/CLI Affects the command line area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanhuhta @ecordell