Propagate context in migrations #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
pkg/migrate/migrate.go
Outdated
| @@ -30,7 +31,7 @@ type Driver interface { | |||
| Version() (string, error) | |||
There was a problem hiding this comment.
Can you also add context to the Version() call as well?
nbarbey
force-pushed
the
main
branch
2 times, most recently
from
73b3cea to
8c2bcc4
Compare
|
@nbarbey Please rebase on main |
|
@nbarbey Mind rebasing one more time? |
| @@ -109,9 +110,9 @@ func (mb *mysqlTester) NewDatabase(t testing.TB) string { | |||
| func (mb *mysqlTester) runMigrate(t testing.TB, dsn string) { | |||
| driver, err := migrations.NewMySQLDriverFromDSN(dsn, mb.options.Prefix) | |||
| require.NoError(t, err, "failed to create migration driver: %s", err) | |||
| err = migrations.Manager.Run(driver, migrate.Head, migrate.LiveRun) | |||
| err = migrations.Manager.Run(context.Background(), driver, migrate.Head, migrate.LiveRun) | |||
There was a problem hiding this comment.
I think the duplication here might be in error
There was a problem hiding this comment.
Indeed, thanks ! This must have slipped through my attention while resolving the rebase conflicts ...
This is to allow timeouts in migration operations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow timeouts in migration operations.
This is related to issue #595 and issue #347.