Update NewEnemy test for datastore v2 #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
jakedt
reviewed
May 19, 2022
ecordell
force-pushed
the
dsv2-newenemy
branch
7 times, most recently
from
7000892 to
862a7b8
Compare
jakedt
previously approved these changes
May 19, 2022
jakedt
approved these changes
May 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated test passed multiple times in another branch (though against a slightly older version of dsv2 branch) but I don't have enough data to confidently say it has an acceptable flake rate.
Temporarily removed the schema-based newenemy test. It would be nice to restore it if possible, but the larger transactions in dsv2 may make that more difficult (it was certainly more difficult for the data-based newenemy test). The protections we have in place are the same for both cases, so schema newenemy test only serves to verify implementation bugs, unlike the data newenemy test which verifies SpiceDB's approach to dealing with timestamp drift in CRDB.