Add a dispatch test that verifies delete preconditions across datastores #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
jakedt
requested changes
Jul 22, 2022
internal/services/dispatch_test.go
Outdated
| }) | ||
| require.NoError(t, werr) | ||
|
|
||
| // Ensure the delete now works. |
There was a problem hiding this comment.
Can you add a MUST_NOT_MATCH after the write to verify that that also fails now.
josephschorr
force-pushed
the
delete-precondition-dispatch-test
branch
from
9fa548d to
a535f14
Compare
josephschorr
force-pushed
the
delete-precondition-dispatch-test
branch
from
a535f14 to
7a9016b
Compare
|
Updated |
jakedt
approved these changes
Jul 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small test for running delete relationships with preconditions against all datastore implementations