Skip checking of permissions for relationships in WriteSchema #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
jzelinskie
reviewed
Aug 2, 2022
This PR changes the namespace diff logic to treat relations and permissions distinctly, thus ensuring that WriteSchema will only check for relationships if a *relation* is removed, and not a permission as well. This was a legacy of the time when relations could contain both data and expressions. Fixes authzed#733
josephschorr
force-pushed
the
permission-diff
branch
from
cee86cc to
a031dd6
Compare
jzelinskie
approved these changes
Aug 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the namespace diff logic to treat relations and permissions distinctly, thus ensuring that WriteSchema will only check for relationships if a relation is removed, and not a permission as well. This was a legacy of the time when relations could contain both data and expressions.
Fixes #733