Fully implement the LookupSubjects API #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
josephschorr
force-pushed
the
lookup-subjects-api
branch
2 times, most recently
from
48a2059 to
92fee9b
Compare
jzelinskie
reviewed
Aug 29, 2022
jzelinskie
reviewed
Aug 29, 2022
josephschorr
force-pushed
the
lookup-subjects-api
branch
from
92fee9b to
5b34f87
Compare
|
Updated |
josephschorr
force-pushed
the
lookup-subjects-api
branch
from
5b34f87 to
f513b85
Compare
This change also fixes a number of issues discovered while testing: 1) Dispatch for lookup subjects has to track wildcard exclusions. For this a new SubjectSet is implemented and tested 2) LookupSubjects was added to the consistency test suite 3) TrackingSubjectSet was changed to be based on the same logic as SubjectSet and tests updated+improved 4) Added additional consistency tests for wildcards and other case
josephschorr
force-pushed
the
lookup-subjects-api
branch
4 times, most recently
from
46dabb5 to
a7375eb
Compare
jzelinskie
requested changes
Aug 29, 2022
josephschorr
force-pushed
the
lookup-subjects-api
branch
from
a7375eb to
8569755
Compare
jzelinskie
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also fixes a number of issues discovered while testing:
Fixes #261