Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle duplicate writes in a nicer way #796

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Handle duplicate writes in a nicer way #796

merged 2 commits into from
Sep 1, 2022

Conversation

josephschorr
Copy link
Member

SpiceDB will now raise an error if a WriteRelationships call contains the same relationship more than once. This PR also validates that this cannot occur during testing, and adds some additional datastore tests around delete and write operations

@josephschorr josephschorr requested review from jzelinskie and a team September 1, 2022 23:45
@github-actions github-actions bot added area/api v1 Affects the v1 API area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Sep 1, 2022
@josephschorr josephschorr merged commit 5c18789 into authzed:main Sep 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2022
@josephschorr josephschorr deleted the write-duplicates branch September 1, 2022 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jzelinskie jzelinskie jzelinskie approved these changes

Assignees
No one assigned
Labels
area/api v1 Affects the v1 API area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephschorr @jzelinskie