Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix more instances of zerolog marshall recursion #922

Merged
merged 1 commit into from
Oct 20, 2022
Merged

fix more instances of zerolog marshall recursion #922

merged 1 commit into from
Oct 20, 2022

Conversation

vroldanbet
Copy link
Contributor

Follow up to #909

Fixes more instances I found of potential stack overflow via zerolog marshalling recursion

@vroldanbet vroldanbet requested review from a team and ecordell October 20, 2022 12:10
@github-actions github-actions bot added area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests labels Oct 20, 2022
@vroldanbet vroldanbet self-assigned this Oct 20, 2022
ecordell
ecordell approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice catch - I thought I grepped for these but apparently missed a few.

@vroldanbet vroldanbet merged commit 2b75a1f into main Oct 20, 2022
@vroldanbet vroldanbet deleted the more-instances-zerolog-recursion branch October 20, 2022 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ecordell ecordell ecordell approved these changes

Assignees

@vroldanbet vroldanbet

Labels
area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vroldanbet @ecordell