Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing caveat test, update caveat example #924

Merged
merged 3 commits into from
Oct 21, 2022
Merged

add missing caveat test, update caveat example #924

merged 3 commits into from
Oct 21, 2022

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Oct 20, 2022 •
edited
Loading

  • test delete caveated relationship with RelationTupleUpdate_DELETE. The caveat is not part of the primary key of the relationship and so it's ignored when it comes to delete operations
  • updates application caveats use-case with "recursing subset" behaviour
  • removes occurences of zerolog/log global logger in favour of SpiceDB's own global logger

@vroldanbet
test delete caveated rel with RelationTupleUpdate_DELETE
b9cc154 
the caveat is not part of the primary key of the relationship
and so it's ignored when it comes to delete operations
@vroldanbet vroldanbet changed the title test missing caveat test add missing caveat test Oct 20, 2022
@github-actions github-actions bot added area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Oct 20, 2022
@vroldanbet vroldanbet force-pushed the additional-caveat-tests branch from 3fff3f5 to 8e2cfd9 Compare October 20, 2022 17:48
@vroldanbet vroldanbet marked this pull request as ready for review October 20, 2022 18:03
@vroldanbet vroldanbet requested review from a team and josephschorr October 20, 2022 18:03
@vroldanbet vroldanbet changed the title add missing caveat test add missing caveat test, update caveat example Oct 20, 2022
@vroldanbet vroldanbet force-pushed the additional-caveat-tests branch from 8e2cfd9 to b5b68d9 Compare October 20, 2022 18:58
josephschorr
josephschorr reviewed Oct 21, 2022
View reviewed changes
pkg/caveats/types/map.go Outdated Show resolved Hide resolved
pkg/datastore/test/caveat.go Show resolved Hide resolved
@vroldanbet vroldanbet force-pushed the additional-caveat-tests branch from b5b68d9 to 8e89dc0 Compare October 21, 2022 17:09
@vroldanbet vroldanbet force-pushed the additional-caveat-tests branch from 8e89dc0 to aed105f Compare October 21, 2022 17:11
josephschorr
josephschorr approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet enabled auto-merge October 21, 2022 17:23
@vroldanbet vroldanbet merged commit 3871326 into main Oct 21, 2022
@vroldanbet vroldanbet deleted the additional-caveat-tests branch October 21, 2022 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
@vroldanbet vroldanbet self-assigned this Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees

@vroldanbet vroldanbet

Labels
area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vroldanbet @josephschorr