Skip to content

Commit

Permalink
chore: use node 18
Browse files Browse the repository at this point in the history
  • Loading branch information
DIYgod committed Mar 19, 2023
1 parent b1d4456 commit 3d6d8eb
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// https://github.com/devcontainers/images/blob/v0.2.24/src/javascript-node/.devcontainer/devcontainer.json
{
"name": "Node.js",
"image": "mcr.microsoft.com/devcontainers/javascript-node:16-bullseye",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",

// Configure tool-specific properties.
"customizations": {
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'yarn'
registry-url: 'https://registry.npmjs.org'
- name: Release
Expand Down
10 changes: 5 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16-bullseye as dep-builder
FROM node:18-bullseye as dep-builder
# Here we use the non-slim image to provide build-time deps (compilers and python), thus no need to install later.
# This effectively speeds up qemu-based cross-build.

Expand Down Expand Up @@ -30,7 +30,7 @@ FROM debian:bullseye-slim as dep-version-parser
# This stage is necessary to limit the cache miss scope.
# With this stage, any modification to package.json won't break the build cache of the next two stages as long as the
# version unchanged.
# node:16-bullseye-slim is based on debian:bullseye-slim so this stage would not cause any additional download.
# node:18-bullseye-slim is based on debian:bullseye-slim so this stage would not cause any additional download.

WORKDIR /ver
COPY ./package.json /app/
Expand All @@ -42,7 +42,7 @@ RUN \

# ---------------------------------------------------------------------------------------------------------------------

FROM node:16-bullseye-slim as docker-minifier
FROM node:18-bullseye-slim as docker-minifier
# The stage is used to further reduce the image size by removing unused files.

WORKDIR /minifier
Expand Down Expand Up @@ -74,7 +74,7 @@ RUN \

# ---------------------------------------------------------------------------------------------------------------------

FROM node:16-bullseye-slim as chromium-downloader
FROM node:18-bullseye-slim as chromium-downloader
# This stage is necessary to improve build concurrency and minimize the image size.
# Yeah, downloading Chromium never needs those dependencies below.

Expand Down Expand Up @@ -104,7 +104,7 @@ RUN \

# ---------------------------------------------------------------------------------------------------------------------

FROM node:16-bullseye-slim as app
FROM node:18-bullseye-slim as app

LABEL org.opencontainers.image.authors="https://github.com/DIYgod/RSSHub"

Expand Down

0 comments on commit 3d6d8eb

Please sign in to comment.