Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.4 - Unifying prefs, logging, setup, and scripts #52

Merged
merged 49 commits into from
Dec 14, 2020
Merged

Conversation

sneakers-the-rat
Copy link
Contributor

@sneakers-the-rat sneakers-the-rat commented Dec 14, 2020

Improvements:

  • Unify the creation of loggers!!!! See the docs ;) https://docs.auto-pi-lot.com/en/latest/autopilot.core.loggers.html : d55638f Structure of Prefs, defaults, & setup #38
  • Unify prefs, including sensible defaults, refactoring of scripts into a reasonable format, multiprocess-safety, and just generally a big weight off my mind. Note that this is a breaking change to the way prefs are accessed. Previously one would do prefs.PREF_NAME, but that made it very difficult to provide default values or handle missing prefs. the new syntax is prefs.get('PREF_NAME') which returns defaults with a warning and None if the pref is not set: c40a212 Structure of Prefs, defaults, & setup #38
  • completely clean up scripts, and together that opened the path to clean up setup as well. so all things configuration got a major promotion
  • We're on the board with CI and automated testing with a positively massive 3% code coverage!!! 743bb8f
  • new scripts to eg. create autopilot alias: 211919b

Bugfixes:

Docs:

  • Clarification of supported systems: ce0ddf7
  • Solved an ancient sphinx riddle of how to get data objects/constants to pretty-print: ec6d5a7
  • Clarify hardware prefs f3a7609
  • what numbering system do we use: 6426724

Logging:

sneakers-the-rat and others added 30 commits October 28, 2020 16:03
added 2AFC_Gap_Laser to new protocol list
…nitialize smartly and unify where it searches once and for all

also still need to make a gentler 'GET' method that reliably returns None rather than raising an attribute error so can remove awkward "if hasattr" calls throughout code
Also need to fix building directory structure from unified prefs.py
- Made logger able to be spawned with explicit naming convention rather than derived from object only
** also made skeleton for running CI tests on travis but none written yet **
and replaced old method of calling prefs
a parameter that was of type 'float' was being dropped because the set_value method from the protocol wizard was written such that if a 'type' didn't match something in its if/elif chain it silently dropped it. 'float' was not in its chain. that's really bad. try to catch the value if we can and it should throw an error if you can't.
@sneakers-the-rat sneakers-the-rat changed the title v0.3.4 v0.3.4 - Unifying prefs, logging, setup, and scripts Dec 14, 2020
@sneakers-the-rat sneakers-the-rat merged commit f1a095e into master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants