-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3.4 - Unifying prefs, logging, setup, and scripts #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2AFC_Gap_Laser to new protocol list
…y make sure to test before releasing!)
…nitialize smartly and unify where it searches once and for all also still need to make a gentler 'GET' method that reliably returns None rather than raising an attribute error so can remove awkward "if hasattr" calls throughout code Also need to fix building directory structure from unified prefs.py - Made logger able to be spawned with explicit naming convention rather than derived from object only ** also made skeleton for running CI tests on travis but none written yet **
and replaced old method of calling prefs
fixing invoker import
a parameter that was of type 'float' was being dropped because the set_value method from the protocol wizard was written such that if a 'type' didn't match something in its if/elif chain it silently dropped it. 'float' was not in its chain. that's really bad. try to catch the value if we can and it should throw an error if you can't.
added some concrete examples to the GPIO numbering documentation
# Conflicts: # docs/guide.installation.rst
sneakers-the-rat
changed the title
v0.3.4
v0.3.4 - Unifying prefs, logging, setup, and scripts
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
prefs.PREF_NAME
, but that made it very difficult to provide default values or handle missing prefs. the new syntax isprefs.get('PREF_NAME')
which returns defaults with a warning andNone
if the pref is not set: c40a212 Structure of Prefs, defaults, & setup #38Bugfixes:
Docs:
Logging: