Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the MACE fit more flexible and build a finetuning workflow #182

Merged
merged 36 commits into from
Nov 10, 2024

Conversation

JaGeo
Copy link
Collaborator

@JaGeo JaGeo commented Oct 25, 2024

Closes #178

  • make all keywords available for the fit (half done - check closely if the current implementation makes sense)
  • check function parameters and see if we need more/less or need to think about an overwriting strategy
  • build a fine-tuning workflow
  • Set useful default settings
  • Seperate forcefields and make sure that they can be used separately (will be important for fine-tuning applications that need the current MACE main branch...)

Currently, this can only be done by cloning the git-repo and installing it from there: []()

It is now important that you switch off the default settings for the fitting procedure (use_defaults_fitting=False).
If one wants to perform very low-data fine-tuning (less than 4 additional structures), please also think about switching off `preprocessing_data`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuantumChemist can you confirm that this is enough to skip the train, test split and simply take all data?

Copy link
Collaborator

@QuantumChemist QuantumChemist Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then the MLIPFitMaker will only run if train.extxyz and test.extxyz files are present in the database_dir

# this will only run if train.extxyz and test.extxyz files are present in the database_dir

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about a way to circumvent this in the future. I will implement a basic implementation first.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was implemented this way by @YuanbinLiu for the RSS part, so we might be careful with the changes until the rest of the RSS part is fully merged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I will only add the option not change the default. This is what I have done for the rest of the implementations here as well. The defaults have not changed.

@JaGeo
Copy link
Collaborator Author

JaGeo commented Nov 10, 2024

@YuanbinLiu FYI, I will merge this and then push a few tiny changes to #203 to fix the merge conflicts. I have prepared everything in #213 already and this should not cause any problems for your pull request.

@JaGeo JaGeo merged commit 0a6deb6 into main Nov 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide finetuning option for phonons based on MACE-MP-0
3 participants