Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstrings, type-hints, documentation fixes #78

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

QuantumChemist
Copy link
Collaborator

@QuantumChemist QuantumChemist commented Jul 4, 2024

improving docstring, adding type-hints, improving documentation

  • docstrings
  • type-hints
  • documentation
    • adding more jobflow-remote documentation

Working through Aakash's suggestions #71 (comment)

@JaGeo
Copy link
Collaborator

JaGeo commented Jul 5, 2024

Let me know when I can merge 😀

@QuantumChemist
Copy link
Collaborator Author

QuantumChemist commented Jul 5, 2024

Let me know when I can merge 😀

I'm adding a few more things for jobflow-remote. Then you can merge :)
(forgot that, only remembered when I was ticking off the finished tasks)

@QuantumChemist
Copy link
Collaborator Author

I added a more detailed jobflow-remote setup tutorial now. It's based on Aakash's documentation for our BAM group.

I deactivated the Actions workflows for Testing_Python to save Actions time. When the previous one https://github.com/QuantumChemist/autoplex/actions/runs/9811364709 has finished, you can merge the PR, @JaGeo 😆

@QuantumChemist QuantumChemist changed the title [WIP] Docstrings, type-hints, documentation fixes Docstrings, type-hints, documentation fixes Jul 5, 2024
@QuantumChemist QuantumChemist added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 5, 2024
@JaGeo JaGeo merged commit c5c7f27 into autoatml:main Jul 5, 2024
@JaGeo
Copy link
Collaborator

JaGeo commented Jul 5, 2024

👀

@naik-aakash
Copy link
Collaborator

I added a more detailed jobflow-remote setup tutorial now. It's based on Aakash's documentation for our BAM group.

I deactivated the Actions workflows for Testing_Python to save Actions time. When the previous one https://github.com/QuantumChemist/autoplex/actions/runs/9811364709 has finished, you can merge the PR, @JaGeo 😆

Hi @QuantumChemist , would you mind also mentioning this in the docs that it was written by me and adapted?

@QuantumChemist
Copy link
Collaborator Author

I added a more detailed jobflow-remote setup tutorial now. It's based on Aakash's documentation for our BAM group.
I deactivated the Actions workflows for Testing_Python to save Actions time. When the previous one https://github.com/QuantumChemist/autoplex/actions/runs/9811364709 has finished, you can merge the PR, @JaGeo 😆

Hi @QuantumChemist , would you mind also mentioning this in the docs that it was written by me and adapted?

Ok done ✅
https://github.com/JaGeo/autoplex/blob/main/docs/user/jobflowremote.md

I hope this is your bam email (not sure if your second name is included).

I only removed the cluster names and sensitive information, and improved the grammar a bit, so it's not necessary to put my name, too. ☺️

@JaGeo
Copy link
Collaborator

JaGeo commented Jul 6, 2024

@QuantumChemist could you add info about the -i?

@QuantumChemist
Copy link
Collaborator Author

@QuantumChemist could you add info about the -i?

You mean when activating the runner? I will do that in the next PR then. I don't want to use up all your action time.

@JaGeo
Copy link
Collaborator

JaGeo commented Jul 6, 2024

No, what the -i means. I don't think every user might need this. I think we still need to add to this documentation.

@QuantumChemist
Copy link
Collaborator Author

No, what the -i means. I don't think every user might need this. I think we still need to add to this documentation.

just to make sure I understand you correctly: are you referring to this?
https://github.com/JaGeo/autoplex/blob/c7828b5dbe2cacb1b2ec683a81d8e935cf90b7a5/docs/user/jobflowremote.md?plain=1#L61

@JaGeo
Copy link
Collaborator

JaGeo commented Jul 6, 2024

Yes, exactly. This means "interactive mode"

@QuantumChemist
Copy link
Collaborator Author

Added more details and basically how the users can help themselves.
https://github.com/QuantumChemist/autoplex/blob/main/docs/user/jobflowremote.md

Will merge it with the next PR to save the Action time for now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants