-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docstrings, type-hints, documentation fixes #78
Conversation
Let me know when I can merge 😀 |
I'm adding a few more things for jobflow-remote. Then you can merge :) |
I added a more detailed jobflow-remote setup tutorial now. It's based on Aakash's documentation for our BAM group. I deactivated the Actions workflows for Testing_Python to save Actions time. When the previous one https://github.com/QuantumChemist/autoplex/actions/runs/9811364709 has finished, you can merge the PR, @JaGeo 😆 |
👀 |
Hi @QuantumChemist , would you mind also mentioning this in the docs that it was written by me and adapted? |
Ok done ✅ I hope this is your bam email (not sure if your second name is included). I only removed the cluster names and sensitive information, and improved the grammar a bit, so it's not necessary to put my name, too. |
@QuantumChemist could you add info about the -i? |
You mean when activating the runner? I will do that in the next PR then. I don't want to use up all your action time. |
No, what the -i means. I don't think every user might need this. I think we still need to add to this documentation. |
just to make sure I understand you correctly: are you referring to this? |
Yes, exactly. This means "interactive mode" |
Added more details and basically how the users can help themselves. Will merge it with the next PR to save the Action time for now 😄 |
improving docstring, adding type-hints, improving documentation
Working through Aakash's suggestions #71 (comment)