Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test v8 backport macos-13-arm64 #106

Closed
wants to merge 1 commit into from
Closed

Test v8 backport macos-13-arm64 #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ jobs:
sdkpaths=( $pattern )
echo "Found SDKROOT: ${sdkpaths[0]}"
echo "HOMEBREW_FAKE_MACOS=13.7.0" >> $GITHUB_ENV
echo "MACOSX_DEPLOYMENT_TARGET=13.0" >> $GITHUB_ENV
echo "SDKROOT=${sdkpaths[0]}" >> $GITHUB_ENV
#echo "MACOSX_DEPLOYMENT_TARGET=13.0" >> $GITHUB_ENV
#echo "SDKROOT=${sdkpaths[0]}" >> $GITHUB_ENV

- name: Set up Homebrew
id: set-up-homebrew
Expand Down
9 changes: 5 additions & 4 deletions Formula/v8-static.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
desc "Google's JavaScript engine"
homepage "https://v8.dev/docs"
# Track V8 version from Chrome stable: https://chromiumdash.appspot.com/releases?platform=Mac
url "https://github.com/v8/v8/archive/refs/tags/12.7.224.16.tar.gz"
sha256 "00425fe7fd851f11839537256922addbfee0f5d27c6bf5ab375b9d0347d8ed94"
url "https://github.com/v8/v8/archive/refs/tags/12.7.224.20.tar.gz"
sha256 "49cee325e57cfb4671e04e955ea87447d86d2f34944691ca5b15389cf4dac1c8"
license "BSD-3-Clause"

bottle do
Expand Down Expand Up @@ -71,7 +71,7 @@
revision: "bfe59c2726fda7494a800f7d0ee461f0564653b3"
end

def install

Check warning on line 74 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64)

`brew install --verbose --formula --build-bottle autobrew/cran/v8-static` failed on macOS Ventura (13) on Apple Silicon! 

[371/1818] touch obj/third_party/abseil-cpp/absl/strings/has_ostream_operator.stamp
[372/1818] TOOL_VERSION=1727112353 ../build/toolchain/apple/linker_driver.py -Wcrl,driver,../../../../../opt/homebrew/opt/llvm/bin/clang++ -B /Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ -Wcrl,strippath,/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip -Wcrl,installnametoolpath,../../../../../opt/homebrew/opt/llvm/bin/llvm-install-name-tool  --target=arm64-apple-macos -Wl,-mllvm,-enable-machine-outliner=never -no-canonical-prefixes -isysroot ../../../../../Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -mmacos-version-min=10.15 -Wl,-ObjC -L/opt/homebrew/opt/llvm/lib/c++ -Wl,-dead_strip -o "./bytecode_builtins_list_generator" "@./bytecode_builtins_list_generator.rsp" 
FAILED: bytecode_builtins_list_generator 
TOOL_VERSION=1727112353 ../build/toolchain/apple/linker_driver.py -Wcrl,driver,../../../../../opt/homebrew/opt/llvm/bin/clang++ -B /Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ -Wcrl,strippath,/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip -Wcrl,installnametoolpath,../../../../../opt/homebrew/opt/llvm/bin/llvm-install-name-tool  --target=arm64-apple-macos -Wl,-mllvm,-enable-machine-outliner=never -no-canonical-prefixes -isysroot ../../../../../Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -mmacos-version-min=10.15 -Wl,-ObjC -L/opt/homebrew/opt/llvm/lib/c++ -Wl,-dead_strip -o "./bytecode_builtins_list_generator" "@./bytecode_builtins_list_generator.rsp" 
ld: library 'System' not found
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "/private/tmp/v8-static-20240923-11214-yzkkur/v8-12.7.224.20/out.gn/../build/toolchain/apple/linker_driver.py", line 389, in <module>
    LinkerDriver(sys.argv).run()
  File "/private/tmp/v8-static-20240923-11214-yzkkur/v8-12.7.224.20/out.gn/../build/toolchain/apple/linker_driver.py", line 172, in run
    subprocess.check_call([self._driver_path] + compiler_driver_args,
  File "/Applications/Xcode_15.4.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../../../../opt/homebrew/opt/llvm/bin/clang++', '-B', '/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/', '--target=arm64-apple-macos', '-Wl,-mllvm,-enable-machine-outliner=never', '-no-canonical-prefixes', '-isysroot', '../../../../../Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk', '-mmacos-version-min=10.15', '-Wl,-ObjC', '-L/opt/homebrew/opt/llvm/lib/c++', '-Wl,-dead_strip', '-o', './bytecode_builtins_list_generator', '@./bytecode_builtins_list_generator.rsp']' returned non-zero exit status 1.
[373/1818] ../../../../../opt/homebrew/opt/llvm/bin/clang++ -MMD -MF obj/third_party/abseil-cpp/absl/status/statusor/statusor.o.d -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_NONE -D__ARM_NEON__=1 -DCR_XCODE_VERSION=1540 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DABSL_ALLOCATOR_NOTHROW=1 -I.. -Igen -I../third_party/abseil-cpp -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -fno-sized-deallocation -fcrash-diagnostics-dir=../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 -ffp-contract=off --target=arm64-apple-macos -mno-outline -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-math-errno -fno-omit-frame-pointer -g2 -gdwarf-aranges -Xclang -debug-info-kind=limited
(buildpath/"build").install resource("v8/build")
(buildpath/"third_party/jinja2").install resource("v8/third_party/jinja2")
(buildpath/"third_party/markupsafe").install resource("v8/third_party/markupsafe")
Expand Down Expand Up @@ -111,6 +111,7 @@
use_custom_libcxx: false, # uses system libc++ instead of Google's custom one
treat_warnings_as_errors: false, # ignore not yet supported clang argument warnings
use_lld: false, # upstream use LLD but this leads to build failure on ARM
clang_base_path: "\"#{Formula["llvm"].opt_prefix}\"", # uses Homebrew clang instead of Google clang
}

if OS.linux?
Expand All @@ -128,11 +129,11 @@
# Undefined symbols for architecture x86_64:
# "std::__1::__libcpp_verbose_abort(char const*, ...)", referenced from:
# std::__1::__throw_length_error[abi:nn180100](char const*) in stack_trace.o
if DevelopmentTools.clang_build_version <= 1400
#if DevelopmentTools.clang_build_version <= 1400

Check failure on line 132 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13) 

Layout/CommentIndentation: Incorrect indentation detected (column 6 instead of 8).

Check failure on line 132 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13) 

Layout/LeadingCommentSpace: Missing space after `#`.

Check failure on line 132 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14) 

Layout/CommentIndentation: Incorrect indentation detected (column 6 instead of 8).

Check failure on line 132 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14) 

Layout/LeadingCommentSpace: Missing space after `#`.

Check failure on line 132 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/CommentIndentation: Incorrect indentation detected (column 6 instead of 8).

Check failure on line 132 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/LeadingCommentSpace: Missing space after `#`.

Check failure on line 132 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/CommentIndentation: Incorrect indentation detected (column 6 instead of 8).

Check failure on line 132 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/LeadingCommentSpace: Missing space after `#`.
gn_args[:fatal_linker_warnings] = false

Check failure on line 133 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13) 

Layout/IndentationConsistency: Inconsistent indentation detected.

Check failure on line 133 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14) 

Layout/IndentationConsistency: Inconsistent indentation detected.

Check failure on line 133 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/IndentationConsistency: Inconsistent indentation detected.

Check failure on line 133 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/IndentationConsistency: Inconsistent indentation detected.
inreplace "build/config/mac/BUILD.gn", "[ \"-Wl,-ObjC\" ]",

Check failure on line 134 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13) 

Layout/IndentationConsistency: Inconsistent indentation detected.

Check failure on line 134 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14) 

Layout/IndentationConsistency: Inconsistent indentation detected.

Check failure on line 134 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/IndentationConsistency: Inconsistent indentation detected.

Check failure on line 134 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/IndentationConsistency: Inconsistent indentation detected.
"[ \"-Wl,-ObjC\", \"-L#{Formula["llvm"].opt_lib}/c++\" ]"
end
#end

Check failure on line 136 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13) 

Layout/LeadingCommentSpace: Missing space after `#`.

Check failure on line 136 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14) 

Layout/LeadingCommentSpace: Missing space after `#`.

Check failure on line 136 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/LeadingCommentSpace: Missing space after `#`.

Check failure on line 136 in Formula/v8-static.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-arm64) 

Layout/LeadingCommentSpace: Missing space after `#`.
end

# Make sure private libraries can be found from lib
Expand Down
Loading