Non generic create #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillig
approved these changes
Oct 21, 2021
|
I can cut a release with this soon. Not today, but next day or so. Thanks! |
|
Thanks Travis for the quick release, I'm using the new nuget package now.
By the way, the code base looks great which encouraged me to take a stab at
a PR (an itch that wanted scratching :-)
…On Wed, Oct 20, 2021 at 8:04 PM Travis Illig ***@***.***> wrote:
I can cut a release with this soon. Not today, but next day or so. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACEKQBIRU6OKSPD54E2PFTUH5KIRANCNFSM5GJY5UAQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
We're definitely open to more PRs if you have 'em. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on being able to switch the instance that gets created based on the type and wasn't able to do that with the provided generic method.
Aligns with the underlying
Autofac.ResolutionExtensions.Resolve