Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Autofac 8. #29

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Update to Autofac 8. #29

merged 2 commits into from
Mar 7, 2024

Conversation

tillig
Copy link
Member

@tillig tillig commented Mar 7, 2024

Update for Autofac 8 compatibility. Includes:

  • Updates to build metadata (.editorconfig, VS Code settings, analyzer rulesets) to match latest Autofac where possible.
  • Update dependencies:
    • Autofac 6.4.0 => 8.0.0
    • System.ComponentModel.Composition 4.5.0 => 8.0.0
  • Add support for net8.0, net7.0, net6.0 to match both Autofac 8 and System.ComponentModel.Composition 8.
  • Fix nullability warnings that popped up with new dependencies, frameworks.

Fixes #28.

@tillig tillig requested a review from alistairjevans March 7, 2024 15:40
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.56%. Comparing base (05de15e) to head (5bac5d0).

Files Patch % Lines
.../Autofac.Integration.Mef/RegistrationExtensions.cs 85.71% 0 Missing and 2 partials ⚠️
...tofac.Integration.Mef/Util/ReflectionExtensions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #29      +/-   ##
===========================================
+ Coverage    71.18%   72.56%   +1.38%     
===========================================
  Files            8        7       -1     
  Lines          347      339       -8     
  Branches        67       68       +1     
===========================================
- Hits           247      246       -1     
+ Misses          69       61       -8     
- Partials        31       32       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, a slight inconsistency in the use of ! vs doing a null check+throw. No big deal though if there's a reason.

@tillig tillig merged commit 5c72269 into develop Mar 7, 2024
4 checks passed
@tillig tillig deleted the feature/autofac-8 branch March 7, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with Autofac 8.0. "Method not found" exception.
2 participants