Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use Autofac parameters for WCF service resolution. #5

Closed
wants to merge 1 commit into from

Conversation

lepberg
Copy link
Contributor

@lepberg lepberg commented Apr 30, 2016

No description provided.

@tillig
Copy link
Member

tillig commented Apr 30, 2016

Hello! Thanks for the PR. Unfortunately, the whole file appears as changed. This usually happens when the line endings get switched. Is there a way to resubmit so we can actually see what changed?

@lepberg
Copy link
Contributor Author

lepberg commented Apr 30, 2016

Hello! Sure, I'll do it.

@lepberg
Copy link
Contributor Author

lepberg commented Apr 30, 2016

Something strange happens here. The git plug-in of Visual Studio displays appropriate file diff, but git diff command says that the whole file is changed and marks the BOM bytes.

a8942148_vsgit
a8942148_gitbash

I tried to explicitly specify EOF, change my autocrlf settings, but nothing has helped.

@lepberg
Copy link
Contributor Author

lepberg commented May 1, 2016

I've created a new pull request to fix related EoF problem.

@tillig
Copy link
Member

tillig commented May 3, 2016

Pulled the EoF request and caught a couple more files that had the same problem. Thanks for the patience and the help!

I think if you can resolve the conflicts this looks like an easy enough change and fairly valuable. Thanks!

@lepberg
Copy link
Contributor Author

lepberg commented May 3, 2016

No problem.
I've just noticed the misspelling in commit "Normalize EoF." that should be "Normalize EoL" of course :(

@lepberg
Copy link
Contributor Author

lepberg commented May 5, 2016

Is there any way to restart appveyor build? I've got no idea why it fails.

@alexmg
Copy link
Member

alexmg commented May 5, 2016

Looks like its a NuGet issue.

NuGet/Home#2648

From the NuSpec reference:

The following table lists attributes of the frameworkAssembly element.

assemblyName Required. The fully qualified assembly name.
targetFramework Optional. If specified, the specific target framework that this reference applies to. For example, if reference only applies to .NET 4, then the value should be "net40". If the reference applies to all frameworks, then omit this attribute.

I tested this was the issue by successfully packing with the targetFramework attribute set on the frameworkAssembly element. I would prefer to leave the targetFramework blank so maybe we just wait for 3.4.4 of NuGet to fix this. We might also have to wait for AppVeyor to start using this version if they don't automatically just pick up the latest released version.

If you can write some passing unit tests in the ServiceHostExtensionsFixture we could pull this in ready for when the new version of NuGet is available. There isn't any obvious issues that I can see.

https://github.com/autofac/Autofac.Wcf/blob/develop/test/Autofac.Integration.Wcf.Test/ServiceHostExtensionsFixture.cs

@lepberg
Copy link
Contributor Author

lepberg commented May 6, 2016

Thanks for explaining the AppVeyor build failure.

@tillig
Copy link
Member

tillig commented May 24, 2018

I did a manual merge of this here.

@tillig tillig closed this May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants